Skip to content

fix: use attribute access for AuthConfig instead of dictionary access#297

Merged
privateip merged 4 commits intoitential:develfrom
wcollins:fix/auth-config-attribute-access
Jan 13, 2026
Merged

fix: use attribute access for AuthConfig instead of dictionary access#297
privateip merged 4 commits intoitential:develfrom
wcollins:fix/auth-config-attribute-access

Conversation

@wcollins
Copy link
Contributor

📒 Description

Fixes server startup failure in v0.11.0 caused by auth.py using dictionary-style access on AuthConfig after the config module was refactored to use frozen Pydantic dataclasses.

Fixes #296

🔍 Type of Change

  • Bug fix

🔧 Changes Made

  • Updated src/itential_mcp/server/auth.py to use attribute access instead of .get() and [] dictionary access
  • Changed type hints from dict[str, Any] to AuthConfig
  • Fixed field name mappings (e.g., redirect_urioauth_redirect_uri)
  • Updated tests to use AuthConfig dataclass instances

🧪 Testing

  • All 2069 tests pass
  • Ruff linter passes with no issues
  • Verified attribute access works correctly for all auth types (none, jwt, oauth, oauth_proxy)

📋 Checklist

  • Code follows the project's style guidelines
  • Self-review of code has been performed
  • Commits follow conventional format (type: subject)
  • No secrets or credentials committed

@wcollins wcollins requested a review from a team as a code owner January 13, 2026 00:42
@wcollins wcollins added the bug Something isn't working label Jan 13, 2026
@privateip privateip merged commit 0bdafef into itential:devel Jan 13, 2026
4 checks passed
privateip added a commit to privateip/itential-mcp that referenced this pull request Jan 16, 2026
- Add AuthConfig attribute access fix (itential#297)
- Add tool discovery tag parsing fix (itential#295)
privateip added a commit that referenced this pull request Jan 16, 2026
- Add AuthConfig attribute access fix (#297)
- Add tool discovery tag parsing fix (#295)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AuthConfig dictionary access causes server startup failure in v0.11.0

2 participants