Fix AuthConfig AttributeError and tool discovery tag parsing#295
Merged
privateip merged 4 commits intoitential:develfrom Jan 14, 2026
Merged
Fix AuthConfig AttributeError and tool discovery tag parsing#295privateip merged 4 commits intoitential:develfrom
privateip merged 4 commits intoitential:develfrom
Conversation
Contributor
Author
|
@privateip Karan reported an issue opening itential-mcp on Claude Desktop. This is an attempt to address it. The fix is a bit involved. Please review carefully. |
Member
|
@AutomateIP can you rebase this PR against the latest please |
1786caf to
02fd7da
Compare
Contributor
Author
done |
privateip
added a commit
to privateip/itential-mcp
that referenced
this pull request
Jan 16, 2026
- Add AuthConfig attribute access fix (itential#297) - Add tool discovery tag parsing fix (itential#295)
Merged
privateip
added a commit
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fix Configuration Access and Tool Discovery
This PR addresses several critical issues identified during server initialization and tool discovery, primarily stemming from the migration to a structured dataclass-based configuration system.
Key Fixes:
1. Configuration Compatibility for Authentication
.get()on an AuthConfig dataclass, resulting in anAttributeError.2. Corrected Middleware Configuration Access
cfg.server_response_formatwas used, which caused anAttributeErrorduring middleware initialization.cfg.server.response_format.3. Robust Tool Discovery for Fully Qualified Modules
itential_mcp.tools.adaptersvs adapters).4. Support for Comma-Separated Tag Filtering
include_tagsandexclude_tags(from config/env) were passed directly to FastMCP, which expects a list. This often resulted in all tools being filtered out.Impact:
These changes ensure the MCP server can start successfully with authentication enabled and correctly populates the available tools list in clients like Claude Desktop.