🐛 fix(logging): implement logging/setLevel via mcp-go upgrade#80
Open
LaelLuo wants to merge 1 commit intoisaacphi:mainfrom
Open
🐛 fix(logging): implement logging/setLevel via mcp-go upgrade#80LaelLuo wants to merge 1 commit intoisaacphi:mainfrom
LaelLuo wants to merge 1 commit intoisaacphi:mainfrom
Conversation
…l args adaptation - Upgrade mcp-go to v0.39.1 which adds server-side handling for `logging/setLevel` and session logging support - Restore `server.WithLogging()` in initialization so clients can set logging level - Adapt tool handlers to new `mcp.CallToolRequest` API using `GetString/GetInt/GetArguments()` instead of indexing `Params.Arguments` - Build succeeds; root `go test` passes; integration tests depend on external LSPs and are unaffected by this fix Fixes isaacphi#79
LaelLuo
force-pushed
the
fix/logging-setlevel
branch
from
cf35e89 to
c8bdbf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
logging/setLeveland session logging supportserver.WithLogging()during initialization so clients can set log levelmcp.CallToolRequestAPI (GetString,GetInt,GetArguments) to keep compatibility with mcp-go >= v0.39Why
Fixes #79: Previously the server declared logging capability but did not implement
logging/setLevel. With mcp-go v0.39.1, the server now implementslogging/setLevel(handleSetLevel), and stdio sessions implementSessionWithLogging.Notes
go build ./...succeedsgo testpasses (integration tests require external language servers and are unaffected by this change)Potential Impact
request.Params.Argumentsdirectly, it should use helper accessors from the updated API.