-
Notifications
You must be signed in to change notification settings - Fork 15
ObjectReferences work with ObjectPlacer #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvolkcvolk
commented
Jan 27, 2026
cvolkcvolk
commented
Jan 27, 2026
cvolkcvolk
commented
Jan 27, 2026
…s_work_object_placer
cvolkcvolk
commented
Jan 29, 2026
viiik-inside
approved these changes
Jan 29, 2026
Collaborator
viiik-inside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing. Just some minor suggestions from my side.
cvolkcvolk
commented
Jan 29, 2026
alexmillane
approved these changes
Jan 30, 2026
Collaborator
alexmillane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for doing that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ObjectReferencecan be used in object placement (as Anchor Objects).Provide
ObjectReferencewith the required fields for it to be able to be used in the Object PlacementObjectReferencepoints to a sub-prim inside the parent's USD, not a separate USD file. Adds a functioncompute_local_bounding_box_from_prim()to get the bbox of the specific sub-prim &apply the parent asset's scale to the resulting bounding box.
Helper function to
center,translateandscaleAxisAlignedBoundingBox, removing some repetitive code.Moved following functions to
ObjectBaseas they can be shared amongObjectandObjectReference.