Add platform specific dynamic library loading #119
Conversation
| // Use dlmopen with LM_ID_NEWLM to load in a new namespace for isolation. | ||
| handle_ = dlmopen(LM_ID_NEWLM, path.c_str(), RTLD_LAZY | RTLD_LOCAL); |
There was a problem hiding this comment.
Was it intentional to not check if the library is already loaded and reuse if so? The previous code was doing that (RTLD_NOLOAD) but the new code always creates a new namespace via LM_ID_NEWLM. Just checking because this could lead to duplicate copies of the library in different namespaces.
There was a problem hiding this comment.
So the idea I had was to support reloading the same library multiple times. It avoids having to manage separately loaded version (e.g. something load the libIreeCompiler.so for its own implementation now having duplicate ownership). One of the problems with core dlopen is that if another took uses the library it could get into an illegal state (because of self counting destroy).
| #include <span> | ||
| #include <sstream> | ||
| #include <string> | ||
| #include <vector> |
There was a problem hiding this comment.
Unrelated to this PR but we should include <cstdint> for the uint8_t type used below. I wonder why clang-tidy didn't catch this before.
There was a problem hiding this comment.
Clang just auto includes core libraries a lot of the time. Not really sure why they chose to do that but they did ¯_(ツ)_/¯
2 participants
Windows differs from Linux in how it loads from dynamic libraries. Adding a support shim to select between platforms allows the libraries to be loaded platform independently.