feat: EmbedMessage WrapV1 option & Reader#ReadEmbeddedMessage#322
Draft
feat: EmbedMessage WrapV1 option & Reader#ReadEmbeddedMessage#322
Conversation
EmbedMessage sets the second-to-leftmost bit to indicate that there is a length-prefixed dag-cbor message object directly after the header. If that bit is set, Reader#ReadEmbeddedMessage will decode and return that message. Ref: ipld/js-car#89
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Just a PoC & proposal at this point, for discussion)
EmbedMessage sets the second-to-leftmost bit to indicate that there is a
length-prefixed dag-cbor message object directly after the header. If that bit
is set, Reader#ReadEmbeddedMessage will decode and return that message.
See ipld/js-car#89 for background and further discussion.