Conversation
hacdias
force-pushed
the
publish-routing
branch
2 times, most recently
from
41cf130 to
9470fd4
Compare
hacdias
force-pushed
the
issues/344
branch
3 times, most recently
from
4661111 to
c583e65
Compare
Member
Author
|
|
hacdias
force-pushed
the
issues/344
branch
2 times, most recently
from
1b12423 to
1b73368
Compare
lidel
reviewed
May 23, 2023
13 tasks
achingbrain
reviewed
May 25, 2023
achingbrain
reviewed
May 25, 2023
hacdias
changed the title
hacdias
changed the title
hacdias
force-pushed
the
masih/dlg_routing_ipns
branch
2 times, most recently
from
8ff9b91 to
8394e23
Compare
hacdias
force-pushed
the
masih/dlg_routing_ipns
branch
from
8394e23 to
4a03ecd
Compare
lidel
force-pushed
the
masih/dlg_routing_ipns
branch
from
b1149d8 to
6d49dfb
Compare
lidel
approved these changes
May 31, 2023
Member
There was a problem hiding this comment.
Lgtm.
Moving to "ready for final review" stage.
Added to the agenda of IPFS Implementers WG call on 2023-06-01 but don't expect issues, it is small and everyone agrees we need this for DHT, Helia, Service Workers, etc.
3 tasks
Member
|
No concerns raised during final ratification during IPFS-Implementers-Sync-2023-06-15, ratified, merging. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #344. Based on #379.