IPIP-351: IPNS Signed Records Response Format on HTTP Gateways #351
Merged
IPIP-351: IPNS Signed Records Response Format on HTTP Gateways #351
Conversation
hacdias
changed the title
11 tasks
hacdias
force-pushed
the
ipns-records-gateway
branch
from
b6a3e2e to
2d8eded
Compare
Member
Author
|
It's ready for review! Implementation too. |
lidel
reviewed
Jan 12, 2023
This was referenced Jan 17, 2023
hacdias
force-pushed
the
ipns-records-gateway
branch
2 times, most recently
from
9874e89 to
8d55e97
Compare
TinyTb
approved these changes
Feb 2, 2023
|
|
||
| ## Detailed design | ||
|
|
||
| The solution is to allow the Gateway to provide an IPNS signed record by |
There was a problem hiding this comment.
Should Gateway be capitalized as it is here? (It's lowercase in other places on this doc)
This was referenced Feb 3, 2023
hacdias
force-pushed
the
ipns-records-gateway
branch
2 times, most recently
from
7d4d566 to
98a41f1
Compare
Member
Author
|
@lidel I just rebased and cleaned up this PR. |
lidel
reviewed
Feb 16, 2023
http-gateways/PATH_GATEWAY.md
Outdated
| - [application/vnd.ipld.dag-cbor](https://www.iana.org/assignments/media-types/application/vnd.ipld.dag-cbor) – requests [IPLD Data Model](https://ipld.io/docs/data-model/) representation serialized into [DAG-CBOR format](https://ipld.io/docs/codecs/known/dag-cbor/). If the requested CID already has `dag-cbor` (0x71) codec, data is validated as DAG-CBOR before being returned as-is. Invalid DAG-CBON produces HTTP Error 500. | ||
| - [application/json](https://www.iana.org/assignments/media-types/application/json) – same as `application/vnd.ipld.dag-json`, unless the CID's codec already is `json` (0x0200). Then, the raw JSON block can be returned as-is without any conversion. | ||
| - [application/cbor](https://www.iana.org/assignments/media-types/application/cbor) – same as `application/vnd.ipld.dag-cbor`, unless the CID's codec already is `cbor` (0x51). Then, the raw CBOR block can be returned as-is without any conversion. | ||
| - [application/vnd.ipfs.ipns-record](https://www.iana.org/assignments/media-types/application/vnd.ipfs.ipns-record) – requests a verifiable [IPNS Record](../ipns/IPNS.md#ipns-record) to be returned. Produces 400 Bad Request if the content is not under the IPNS namespace, or contains a path. |
Member
There was a problem hiding this comment.
💭 need to register before merging
lidel
reviewed
Feb 16, 2023
lidel
reviewed
Feb 16, 2023
lidel
reviewed
Feb 16, 2023
lidel
reviewed
Feb 16, 2023
lidel
reviewed
Feb 16, 2023
2 tasks
hacdias
force-pushed
the
ipns-records-gateway
branch
from
c2d9055 to
7ce972e
Compare
hacdias
force-pushed
the
ipns-records-gateway
branch
3 times, most recently
from
5e34d7b to
fddaa93
Compare
Member
Author
Contributor
|
From @lidel: Will try to take care of IANA things this week and either way can merge by the end of the week (5/12/23) |
hacdias
force-pushed
the
ipns-records-gateway
branch
3 times, most recently
from
c2a4779 to
b36ccf1
Compare
hacdias
force-pushed
the
ipns-records-gateway
branch
from
b36ccf1 to
1ac8ecb
Compare
lidel
approved these changes
May 9, 2023
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
This IPIP got ratified before Kubo 0.19, but we had no time to finalize editorials.
Pushed final tweaks, and references to text fixtures/asserts implementers could follow.
Merging. IANA submission will be tracked in ipfs/in-web-browsers#209
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #320.
Checklist
application/vnd.ipfs.ipns-recordwith IANA (@lidel)ipns-recordcode to the table (Add IPNS Record code multiformats/multicodec#312) and mention it in the spec so people don't useipnsnamespace one