Skip to content

chore: go-multicodec v0.7.0#9350

Merged
lidel merged 1 commit intomasterfrom
chore/update-multicodecs
Nov 8, 2022
Merged

chore: go-multicodec v0.7.0#9350
lidel merged 1 commit intomasterfrom
chore/update-multicodecs

Conversation

@lidel
Copy link
Member

@lidel lidel commented Oct 17, 2022

(let's see if BREAKING CHANGE from this release breaks anything in our CI tests)

BREAKING CHANGES

👉 ipfs code silently changed from 0x01a5 to 0xe3

@lidel lidel self-assigned this Oct 17, 2022
@lidel lidel force-pushed the chore/update-multicodecs branch from f6f251b to dcda277 Compare October 17, 2022 15:43
@lidel lidel marked this pull request as ready for review October 17, 2022 16:03
@lidel
Copy link
Member Author

lidel commented Oct 17, 2022

CI is green – looks fine so far. Pinged folks for review fomstly for visibility.

I don't think the ipfs code change breaks anything in Kubo stack we've renamed multiaddrs from /ipfs/{peerid} to /p2p/{peerid} long time ago, and the code does not seem to be used in content-addressed data context.

BUT, I suspect this change might impact some downstream projects that hardcoded ipfs-ns in context of content-paths (ENS?) or ipfs in context of Multiaddrs.

👉 we should document this in release notes for 0.17 under "BREAKING CHANGES" section.

@lidel lidel force-pushed the chore/update-multicodecs branch from dcda277 to 880e889 Compare November 8, 2022 15:56
@lidel lidel merged commit d69f7a5 into master Nov 8, 2022
@lidel lidel deleted the chore/update-multicodecs branch November 8, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants