Conversation
299c247 to
c0bb34e
Compare
|
@guseggert and @iand : this work and #9169 have beeen open for 6+ months. Is it still relevant? |
|
This was waiting for bifrost to test this on the gateways but they never finished it that integration. Being able to answer "why was a request slow" or "why did this request time out" seems like a useful thing to have....... |
|
Will definitely be useful in Thunderdome |
|
Yeah maybe we can wire it up in Thunderdome and use that to get this over the line then? Do you have bandwidth for that right now @iand ? |
c0bb34e to
44282ce
Compare
|
I repurposed this PR to include ipfs/boxo#256 and the test from #9180. I'll see if the sharness test is properly working, had some issues locally. |
320885f to
8dcf3c5
Compare
07c4f1b to
e14ceab
Compare
|
I updated this PR. I think it is ready. Before reviewing, please read ipfs/boxo#256 (comment). |
e14ceab to
4696258
Compare
This should enable trace context propagation from headers in the HTTP Gateway and APIs.
4696258 to
f7e3c1a
Compare
| } | ||
| }() | ||
| otel.SetTracerProvider(tp) | ||
| otel.SetTextMapPropagator(autoprop.NewTextMapPropagator()) |
There was a problem hiding this comment.
I would like to understand what this does, because this isn't setuped yet, however http propagation already works for cmds.
There was a problem hiding this comment.
@Jorropo https://pkg.go.dev/go.opentelemetry.io/contrib/propagators/autoprop@v0.40.0#pkg-overview, for more info ask @guseggert since he added this. AFAIK, the main goal is that it parses the ENV variable and has sensible defaults.
However, it might not make sense since we always use tracing.Propagators() explciitly, so we're never using the default.
There was a problem hiding this comment.
If we don't use it, I would say let's not do this. Deadcode is bad.
There was a problem hiding this comment.
I'm a little hazy here because this was so long ago, but presumably I was trying to make the propagation user-configurable with OTel standard environment variables. I wouldn't say this is dead code as the intention is to allow users to wire up OTel in their applications, although this could use some tests.
There was a problem hiding this comment.
@guseggert @Jorropo I extracted my commit to #9798.
@guseggert if you want to use autoprop, I think you should either use it as the return value for tracing.Propagators, or set it as default and completely remove tracing.Propagators. But that is not in the scope of what I'm trying to achieve here, so I'll mark this again as a draft.
f7e3c1a to
8dc49c0
Compare
|
Superseded by #9801 |
This should enable trace context propagation from headers in the HTTP Gateway and APIs.
I think this should have a sharness test to ensure propagation doesn't break, so I'll leave this in draft for now.
Superseds #9180