This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Merged
Conversation
lidel
force-pushed
the
fix/require-v2-signatures
branch
from
56e2bcc to
65aa94f
Compare
ipfs/js-ipns#180 BREAKING CHANGE: IPNS V1 signatures are ignored, records without V2 signature are no longer marked as Valid.
lidel
force-pushed
the
fix/require-v2-signatures
branch
from
65aa94f to
4adda36
Compare
lidel
changed the title
Member
Author
|
@achingbrain switched this PR to js-ipns v3.0.0, ready for your final review. We are planning to release ipfs/kubo#9265 in Kubo 0.16 RC this/next week, so would be good to ship JS version in the next JS-IPFS release too. |
achingbrain
approved these changes
Sep 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes js-ipfs ignore V1 signatures when validating IPNS records, and always require V2.
See ipfs/js-ipns#180 for low level details (needs that to be released before merging this)
Closes #4197
BREAKING CHANGE: IPNS Records that do not have V2 but have V1 signature will no longer pass validation, even if V1 is correct. V2 is mandatory to pass validation. See "Record validation" in ipfs/specs#319 for details.