Open
Conversation
Contributor
Author
|
Does a lookup function need to be registered with |
Contributor
Author
|
I'm considering checking the current subscribers for the topic directly before the fetch call. The check would see if we are still pubsub peered with the peerId that is being queried with the fetch call. If not then cancel the fetch and return. This would reduce the possibility of opening a new connection instead of just a new stream. |
|
Triage:
|
The existing functionality breaks assumptions of the { cache: boolean } option of ipns.resolve
The PubSubRouting.get method now only adds topics to watch which allows
users to listen for updates to those keys.
This solution is better than using libp2p/fetch to query each pubsub
peer on each get call.
Contributor
Author
|
I've made some changes to PubSubRouting.
Usage: const pubsubRouter = pubsub(components)
pubsubRouter.addEventListener('record-update', ({ publicKey, record }) => console.log(`New record for ${publicKey}`))
const names = ipns(components, { routers: [pubsubRouter] })
// init PubSubRouting for names of interest
await names.resolve(ipnsKey) |
achingbrain
requested changes
Jan 23, 2026
Member
achingbrain
left a comment
There was a problem hiding this comment.
Looks good, thanks for opening this. Comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
feat: ipns libp2p fetch
Description
Adds
@libp2p/fetchfunctionality to the pubsub router ofhelia/ipns.The pubsub router will libp2p/fetch the latest local record from new pubsub peers if libp2p.services.fetch is found.
https://specs.ipfs.tech/ipns/ipns-pubsub-router/#layering-persistence-onto-libp2p-pubsub
Closes #893
Notes & open questions
Should
getmethod of the pubsub router wait for a few peers to be queries with fetch, or should the router emit an event when it finds a newer record?Change checklist