gateway: add Content-Location for non-default response formats#603
Merged
gateway: add Content-Location for non-default response formats#603
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 59.72% 60.57% +0.84%
==========================================
Files 238 238
Lines 29831 29462 -369
==========================================
+ Hits 17817 17846 +29
+ Misses 10405 10001 -404
- Partials 1609 1615 +6
|
92fc636 to
de679ed
Compare
Member
Author
|
@lidel before I open a PR for the specifications, we should decide what to do with CAR requests that contain "parameters" in the These cannot be translated into query URL parameters, so the |
lidel
requested changes
Apr 16, 2024
Member
Author
|
@lidel I've opened a PR in the specs repository: ipfs/specs#471 |
lidel
approved these changes
Apr 18, 2024
91fdd90 to
0585641
Compare
Co-authored-by: Marcin Rataj <lidel@lidel.org>
0585641 to
f96974f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/orgs/ipshipyard/projects/1/views/1?pane=issue&itemId=58406852
Close #606
Specs PR: ipfs/specs#471