routing/http: add more type and WithDynamicProviderInfo#443
Closed
routing/http: add more type and WithDynamicProviderInfo#443
Conversation
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 50.11% 49.50% -0.61%
==========================================
Files 249 246 -3
Lines 29998 29950 -48
==========================================
- Hits 15033 14827 -206
- Misses 13532 13687 +155
- Partials 1433 1436 +3
|
7ae3e0d to
a97f44f
Compare
Member
Contributor
Author
|
@hacdias this is a pretty simple change that adds a callback instead of statically hardcoding the listen addresses, I would be surprised if this can't be forward ported. |
Member
|
@Jorropo feel free to rebase and ping me after. |
Contributor
Author
|
I'll probably do that for Kubo v0.24 |
Contributor
|
2023-10-05 conversation: we aren't going to invest time in this until /routing/v1 PUTs get addressed: ipfs/specs#378. We aren't spending time fixing bugs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to fix a bug in Kubo where we advertise the listening addresses.
We can't pass our real addresses once since thing like autonat takes time.