Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- Added support for `exclude_none` and `exclude_unset` in `save` method.

## Fixed

- Switched Firestore `query.where()` to use the 'filter' keyword argument instead of
positional arguments. This eliminates a UserWarning that was introduced in
`google-cloud-firestore` 2.11.0.

## [0.8.1] - 2024-12-09

### Changed
Expand Down
3 changes: 2 additions & 1 deletion firedantic/_async/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ def _add_filter(
query: AsyncQuery = query.where(filter=_filter) # type: ignore
return query
else:
query: AsyncQuery = query.where(field, "==", value) # type: ignore
_filter = FieldFilter(field, "==", value)
query: AsyncQuery = query.where(filter=_filter) # type: ignore
return query

@classmethod
Expand Down
3 changes: 2 additions & 1 deletion firedantic/_sync/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ def _add_filter(
query: BaseQuery = query.where(filter=_filter) # type: ignore
return query
else:
query: BaseQuery = query.where(field, "==", value) # type: ignore
_filter = FieldFilter(field, "==", value)
query: BaseQuery = query.where(filter=_filter) # type: ignore
return query

@classmethod
Expand Down