Skip to content

Inset fix #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
td-tomasz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Inset fix #534

td-tomasz wants to merge 1 commit into from

Conversation

@td-tomasz
Copy link

@td-tomasz td-tomasz commented Jun 30, 2023

Change the values in the android:inset attributes to fix the black bars that occur when icons are displayed in some launchers.

@td-tomasz
Change the values in the android:inset attributes to fix the black ba…
005aa9e 
…rs that occur when icons are displayed in some launchers
@td-tomasz
Copy link
Author

td-tomasz commented Jul 13, 2023

@mlynch Any news?

@lil5 lil5 mentioned this pull request Jun 24, 2024
Open
trinitiwowka
trinitiwowka reviewed Jul 9, 2024
View reviewed changes
src/platforms/android/index.ts
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background>
<inset android:drawable="@mipmap/ic_launcher_background" android:inset="16.7%" />
<inset android:drawable="@mipmap/ic_launcher_background" android:inset="16.666666666666668%" />
Copy link

@trinitiwowka trinitiwowka Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! it's not enough for API 34. just use 16.6%

ZaLiTHkA added a commit to ZaLiTHkA/capacitor-assets that referenced this pull request Mar 23, 2025
@ZaLiTHkA
fix: repair Android Adaptive Icon "inset"
da23f98 
source: ionic-team#534
@maxmumford
Copy link

maxmumford commented Aug 1, 2025

While we wait for this PR to be merged, you can use this trapeze config to update the inset after image generation:

platforms:
  android:
    xml:
      - resFile: mipmap-anydpi-v26/ic_launcher.xml
        target: adaptive-icon/*/inset
        attrs:
          android:inset: 16.6%
      - resFile: mipmap-anydpi-v26/ic_launcher_round.xml
        target: adaptive-icon/*/inset
        attrs:
          android:inset: 16.6%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@trinitiwowka trinitiwowka trinitiwowka left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@td-tomasz @maxmumford @trinitiwowka