Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

plugins {
id("buildlogic.fusion-common-conventions")
id("buildlogic.java-common-conventions")
id("jacoco-report-aggregation")
id("test-report-aggregation")
Expand All @@ -20,6 +21,7 @@ dependencies {
tasks.check {
dependsOn(tasks.named<JacocoReport>("testCodeCoverageReport"))
dependsOn(tasks.named<TestReport>("testAggregateTestReport"))
dependsOn(fcovAggregateReport)
}

tasks.named<JacocoReport>("testCodeCoverageReport") {
Expand All @@ -33,3 +35,46 @@ tasks.named<JacocoReport>("testCodeCoverageReport") {
tasks.named<TestReport>("testAggregateTestReport") {
destinationDirectory = reporting.baseDirectory.dir("tests")
}


//======================================================================================
// Fusion coverage aggregate report

// Declare the dataDirs for aggregate reporting.
dependencies {
"fcovReportData"(project(path = ":runtime", configuration = "fcovData"))
}


// The task is here instead of the conventions file because it is tied to the CLI's
// classpath, which can't be used from every subproject (notably `runtime`).

val fcovReportData by configurations.getting
val fcovReportDir = reporting.baseDirectory.dir("fcov")

val fcovAggregateReport = tasks.register<JavaExec>("fcovAggregateReport") {
group = "verification"
description = "Generates Fusion code coverage report"

dependsOn(fcovReportData)
outputs.dir(fcovReportDir)

javaLauncher = javaToolchains.launcherFor {
languageVersion = java.toolchain.languageVersion
}

classpath = project(":sdk").sourceSets["main"].runtimeClasspath
mainClass = "dev.ionfusion.fusion.cli.Cli"
args = listOf("report_coverage",
"--configFile", "fcov.properties",
"--htmlDir", fcovReportDir.get().asFile.path) +
fcovReportData.files.map { it.toString() }

enableAssertions = true

doFirst {
// Print the fcovReportData artifacts for easy debugging.
logger.lifecycle("Reporting Fusion coverage data from: ${fcovReportData.files}")
// TODO This information should appear in the report itself.
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
// Copyright Ion Fusion contributors. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

// Conventions for Fusion projects.

plugins {
base
java // This is too much, but I can't find `reporting` and `check` otherwise.
}


// Paths for Fusion code coverage.
val fcovConfig = layout.projectDirectory.file("fcov.properties")
val fcovDataDir = layout.buildDirectory.dir("fcov")
val fcovReportDir = reporting.baseDirectory.dir("fcov")


//=============================================================================
// Code Coverage Data Collection

tasks.named<Test>("test") {
// Rerun tests if the coverage config changes; we might record different things.
inputs.file(fcovConfig)
outputs.dir(fcovDataDir)

jvmArgumentProviders.add(::instrumentationArguments)
}

private fun instrumentationArguments(): List<String> {
// Only collect coverage data when the `fcovTestCollect` task is needed.
if (!gradle.taskGraph.hasTask(fcovTestCollect.get())) {
return emptyList()
}

logger.lifecycle("Enabling Fusion code coverage instrumentation")
return listOf(
"-Ddev.ionfusion.fusion.coverage.DataDir=${fcovDataDir.get().asFile.path}",
"-Ddev.ionfusion.fusion.coverage.Config=${fcovConfig.asFile.path}"
)
}


// Signal the test task to collect Fusion coverage data.
val fcovTestCollect = tasks.register("fcovTestCollect") {
dependsOn(tasks.named<Test>("test"))
outputs.dir(fcovDataDir)
doLast {
logger.lifecycle("Collected Fusion coverage data into ${fcovDataDir.get().asFile.path}")
}
}

tasks.check {
// To speed up the dev cycle, only instrument for coverage when running full checks.
dependsOn(fcovTestCollect)
}


//=============================================================================
// Code Coverage Reporting

// Consumable configuration for providing access to coverage data.
val fcovData by configurations.creating {
description = "Fusion code coverage data"
isCanBeConsumed = true
isCanBeResolved = false
}

artifacts {
add("fcovData", fcovDataDir) {
builtBy(fcovTestCollect)
// ...indirectly: `test` make the artifacts when `fcovTestCollect` is enabled.
}
}


// Resolvable configuration for reporting to gather all the coverage data.
val fcovReportData by configurations.creating {
description = "Fusion code coverage data to report"
isCanBeConsumed = false
isCanBeResolved = true
}

// The reporting task is in the root project, since it needs the CLI classpath.
4 changes: 4 additions & 0 deletions fcov.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Copyright Ion Fusion contributors. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

IncludedModules = /fusion
52 changes: 3 additions & 49 deletions runtime/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

plugins {
id("buildlogic.fusion-common-conventions")
id("buildlogic.java-library-conventions")
jacoco
}
Expand Down Expand Up @@ -31,11 +32,6 @@ java {
val mainFusionRepo = layout.projectDirectory.dir("src/main/fusion")
val testFusionRepo = layout.projectDirectory.dir("src/test/fusion")

// New output paths for Fusion code coverage.
val fcovConfig = layout.projectDirectory.file("fcov.properties")
val fcovDataDir = layout.buildDirectory.dir("fcov")
val fcovReportDir = reporting.baseDirectory.dir("fcov")


// Various resources refer to the current version label.
tasks.processResources {
Expand Down Expand Up @@ -63,19 +59,7 @@ tasks.test {
// dev.ionfusion.fusion.ClassLoaderModuleRepositoryTest uses ftst-repo.jar.
dependsOn(ftstRepo)

inputs.file(fcovConfig)
inputs.dir(testFusionRepo)

jvmArgumentProviders.add {
if (fcovRunning) {
logger.lifecycle("Enabling Fusion code coverage instrumentation")
listOf("-Ddev.ionfusion.fusion.coverage.DataDir=" + fcovDataDir.get().asFile.path,
"-Ddev.ionfusion.fusion.coverage.Config=" + fcovConfig.asFile.path)
}
else {
listOf()
}
}
}

val ftstRepo = tasks.register<Jar>("ftstRepo") {
Expand All @@ -90,7 +74,7 @@ val ftstRepo = tasks.register<Jar>("ftstRepo") {


//=============================================================================
// Code Coverage
// Java Code Coverage

// https://docs.gradle.org/current/userguide/jacoco_plugin.html

Expand Down Expand Up @@ -127,35 +111,6 @@ tasks.check {
}


// Name is ick but mirrors jacocoTestReport
val fcovTestReport = tasks.register<JavaExec>("fcovTestReport") {
dependsOn(tasks.test)

group = "verification"
description = "Generates Fusion code coverage report"

javaLauncher = javaToolchains.launcherFor {
languageVersion = java.toolchain.languageVersion
}

classpath = sourceSets["main"].runtimeClasspath
mainClass = "dev.ionfusion.fusion.cli.Cli"
args = listOf("report_coverage",
"--configFile", fcovConfig.asFile.path,
"--htmlDir", fcovReportDir.get().asFile.path,
fcovDataDir.get().asFile.path)

enableAssertions = true
}


// Signal the test task to collect Fusion coverage data.
var fcovRunning = false
gradle.taskGraph.whenReady {
fcovRunning = hasTask(fcovTestReport.get())
}


//=============================================================================
// Documentation

Expand Down Expand Up @@ -185,6 +140,5 @@ tasks.javadoc {
// Distribution

tasks.build {
// To speed up the dev workflow, only enable FCOV when doing a full build.
dependsOn(tasks.jacocoTestReport, fcovTestReport)
dependsOn(tasks.jacocoTestReport)
}