Adding regime code page #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Adds the missing RegimeCode documentation page so links to /draft-0/tax/regime_code resolve correctly in the published docs.
Changes:
- Added a new
draft-0/tax/regime_code.mdxpage documentingtax.RegimeCodeand its supported values. - Linked the new page into the Mintlify navigation via
docs.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| draft-0/tax/regime_code.mdx | Introduces the missing RegimeCode schema page and enumerates supported regime identifiers. |
| docs.json | Adds the new page to the “Schemas (Draft 0) → Tax” navigation so it’s discoverable and not orphaned. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+16
| ## Values | ||
|
|
||
| | Code | Country | | ||
| |-------|------------------------------| | ||
| | `AE` | United Arab Emirates | |
There was a problem hiding this comment.
For consistency with other enum docs under ## Values (e.g. draft-0/l10n/tax_country_code.mdx, draft-0/currency/code.mdx), this table should use the same column headings (Value | Title | Description). Right now it uses Code | Country, which makes the generated docs inconsistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: we have a broken link at https://docs.gobl.org/draft-0/tax/regime_code. It seems this should be self generated, but it's not.
Tried to do this from the gobl repo, but Cursor was mangling everything and we couldn't figure out how to fix it elegantly. Instead, I'm manually generating the page and assigning a ticket in Linear for this to be fixed as it should.