-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Schema Nullables #11092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix Schema Nullables #11092
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
CodSpeed Performance ReportMerging this PR will not alter performanceComparing
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11092 +/- ##
=======================================
Coverage 88.16% 88.17%
=======================================
Files 1290 1290
Lines 58174 58174
Branches 1969 1969
=======================================
+ Hits 51290 51293 +3
+ Misses 6393 6390 -3
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The API diff comparison is failing here |
bcd0aea to
cdb14d0
Compare
No idea why: the entire diff fits on one screen for me when I run it locally. I just rebased to make sure I'm up to date with master and I'll look into it more if that fails again. |
|
the diff seams small on my local instance as well; looking into it |
|
I found a tool that gives a browser-viewable version of the generated change log and it is indeed massive (in part because changes to parameters makes it report changes to everywhere parameters are available). I should have time this afternoon to figure out if this is valid or if I need to split my changes to make the diff easier to review. |
21cd937 to
d7f6937
Compare
|
Long story short: changing the schema for parameters (such as allowing I rebased to pick up the new api_version changes and reduced the scope of my changes to try to fit within the tool for easier review. |
I finally caught back up to recent schema changes. Here's a small batch of added
allow_nullannotations for nullableread_onlyfields.I also removed the default value of '' because that's not a valid selection from the choices list (which was resulting in code generated from the schema failing to compile). As far as I've spotted the changes to parameter/parameter template don't result in changes to the UI.