Skip to content

Conversation

@1337joe
Copy link
Contributor

@1337joe 1337joe commented Jan 7, 2026

I finally caught back up to recent schema changes. Here's a small batch of added allow_null annotations for nullable read_only fields.

I also removed the default value of '' because that's not a valid selection from the choices list (which was resulting in code generated from the schema failing to compile). As far as I've spotted the changes to parameter/parameter template don't result in changes to the UI.

@netlify
Copy link

netlify bot commented Jan 7, 2026

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit d7f6937
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/69608f228c35c70008456bfb

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 1337joe:fix_api_nullables (d7f6937) with master (02a95ff)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 44 untouched benchmarks
⏩ 29 skipped benchmarks1

Footnotes

  1. 29 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.17%. Comparing base (02a95ff) to head (d7f6937).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11092   +/-   ##
=======================================
  Coverage   88.16%   88.17%           
=======================================
  Files        1290     1290           
  Lines       58174    58174           
  Branches     1969     1969           
=======================================
+ Hits        51290    51293    +3     
+ Misses       6393     6390    -3     
  Partials      491      491           
Flag Coverage Δ
backend 89.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 92.02% <ø> (ø)
Backend General 93.51% <ø> (ø)
Frontend 70.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SchrodingersGat
Copy link
Member

WARN: diff exceeds the 1MB limit, truncating output...

The API diff comparison is failing here

@1337joe 1337joe force-pushed the fix_api_nullables branch from bcd0aea to cdb14d0 Compare January 7, 2026 13:06
@1337joe
Copy link
Contributor Author

1337joe commented Jan 7, 2026

WARN: diff exceeds the 1MB limit, truncating output...

The API diff comparison is failing here

No idea why: the entire diff fits on one screen for me when I run it locally. I just rebased to make sure I'm up to date with master and I'll look into it more if that fails again.

@matmair
Copy link
Contributor

matmair commented Jan 7, 2026

the diff seams small on my local instance as well; looking into it

@matmair matmair added api Relates to the API refactor labels Jan 8, 2026
@matmair matmair added this to the 1.2.0 milestone Jan 8, 2026
@1337joe
Copy link
Contributor Author

1337joe commented Jan 8, 2026

I found a tool that gives a browser-viewable version of the generated change log and it is indeed massive (in part because changes to parameters makes it report changes to everywhere parameters are available). I should have time this afternoon to figure out if this is valid or if I need to split my changes to make the diff easier to review.

@1337joe 1337joe force-pushed the fix_api_nullables branch from 21cd937 to d7f6937 Compare January 9, 2026 05:16
@1337joe
Copy link
Contributor Author

1337joe commented Jan 9, 2026

Long story short: changing the schema for parameters (such as allowing updated_by_detail to be nullable) results in reported changes for every api that has a detail field that includes parameters.

I rebased to pick up the new api_version changes and reduced the scope of my changes to try to fit within the tool for easier review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Relates to the API refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants