Skip to content

Conversation

@matmair
Copy link
Contributor

@matmair matmair commented Nov 10, 2025

Improve MFA experience when MFA enforcement gets enabled.
Closes #10754

@matmair matmair self-assigned this Nov 10, 2025
@matmair matmair added setup Relates to the InvenTree setup / installation process User Interface Related to the frontend / User Interface labels Nov 10, 2025
@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 2908ea4
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/695d9cb1e25a3000088a79dd
😎 Deploy Preview https://deploy-preview-10796--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@matmair matmair added this to the 1.2.0 milestone Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.16%. Comparing base (5b290f4) to head (2908ea4).
⚠️ Report is 1 commits behind head on master.

❌ Your patch check has failed because the patch coverage (88.88%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10796      +/-   ##
==========================================
- Coverage   88.16%   88.16%   -0.01%     
==========================================
  Files        1290     1290              
  Lines       58145    58153       +8     
  Branches     1969     1969              
==========================================
+ Hits        51265    51271       +6     
- Misses       6389     6391       +2     
  Partials      491      491              
Flag Coverage Δ
backend 89.46% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 92.01% <ø> (ø)
Backend General 93.47% <88.88%> (-0.01%) ⬇️
Frontend 70.85% <ø> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will create unknown performance changes

Comparing matmair:fix_mfa_enforce_sessions (2908ea4) with master (025f6ff)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

🆕 29 new benchmarks
⏩ 2 skipped benchmarks2

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 WallTime test_api_part_list N/A 967 ms N/A
🆕 WallTime test_api_stock_list N/A 1.1 s N/A
🆕 WallTime test_api_list_performance[/api/stock/] N/A 161.4 ms N/A
🆕 WallTime test_api_auth_performance N/A 655.4 ms N/A
🆕 WallTime test_api_options_performance[/api/build/item/] N/A 205.2 ms N/A
🆕 WallTime test_api_options_performance[/api/order/po/] N/A 48.3 ms N/A
🆕 WallTime test_api_list_performance[/api/part/category/] N/A 17 ms N/A
🆕 WallTime test_api_options_performance[/api/build/line/] N/A 298.1 ms N/A
🆕 WallTime test_api_options_performance[/api/user/roles/] N/A 6.2 ms N/A
🆕 WallTime test_api_options_performance[/api/order/so/] N/A 54.4 ms N/A
🆕 WallTime test_api_options_performance[/api/build/] N/A 58 ms N/A
🆕 WallTime test_api_list_performance[/api/part/] N/A 90.4 ms N/A
🆕 WallTime test_api_options_performance[/api/parameter/template/] N/A 9 ms N/A
🆕 WallTime test_api_options_performance[/api/parameter/] N/A 12.9 ms N/A
🆕 WallTime test_api_options_performance[/api/order/so/shipment/] N/A 53 ms N/A
🆕 WallTime test_api_list_performance[/api/order/so/] N/A 41.3 ms N/A
🆕 WallTime test_api_list_performance[/api/company/] N/A 19 ms N/A
🆕 WallTime test_api_list_performance[/api/build/] N/A 42.8 ms N/A
🆕 WallTime test_api_options_performance[/api/stock/location/] N/A 15.9 ms N/A
🆕 WallTime test_api_list_performance[/api/order/so/shipment/] N/A 21.4 ms N/A
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. No successful run was found on master (5b290f4) during the generation of this report, so 025f6ff was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

setup Relates to the InvenTree setup / installation process User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MFA Issues

1 participant