-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(backend): add tipps endpoint #10715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (85.29%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #10715 +/- ##
==========================================
- Coverage 88.17% 84.03% -4.14%
==========================================
Files 1289 1297 +8
Lines 58046 63663 +5617
Branches 1973 1997 +24
==========================================
+ Hits 51181 53499 +2318
- Misses 6374 9667 +3293
- Partials 491 497 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…add-tipps-model
…add-tipps-model
…add-tipps-model
…add-tipps-model
|
@SchrodingersGat ready for review; still working out a few lines for the contrib docs but done otherwise |
|
@matmair can you provide some more context here, perhaps some examples of what these guides might look like? And, do we need to add any documentation around this? |
|
@SchrodingersGat I have moved guides to the next PRs This PR lays the backend/frontend foundation for tipp / guide handling. There are new models to handle general tipps/guides and how/when they were executed; The PR also includes the generic frontend components to handle displaying the tipps/guides depending on the current user and their past states. Guides are defined in the backend: Calling a tipp in the frontend is pretty simple |
|
Just curious, what is the usecase of defining them on the backend rather than hardcoding them into the frontend? Can that be used by plugins? Are they still translated and actually show the correct language the user has selected? |


Adds models, API endpoints and frontend components to show tipps in the frontend dependent on various conditions
TODO
Todo next:
Required for #2907 and #2284
Follow up to #7995