feat(vcs): service layer #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
palkerecsenyi
force-pushed
the
service-layer
branch
from
6258bfd to
426ae7a
Compare
palkerecsenyi
force-pushed
the
service-layer
branch
2 times, most recently
from
65f8785 to
1ba8284
Compare
* Created a new VCSService class to act as the 'glue' between the new generic provider API methods and the view handlers, with mostly higher-level methods that combine multiple API calls and reads/writes to the DB. * Also included the modified VCSRelease class in the same file. This has been kept to maintain good compatibility with InvenioRDM and anyone else who might have overriden it. However, it has been updated to support the new generic structure. There have also been some small changes such as the variable naming (`release_object` and `release_payload` to `db_release` and `generic_release` to make more clear where the data comes from). * The OAuth handlers, tasks, and webhook receivers are also updated as part of this PR, again with small changes to make them compatible with the generic structure.
palkerecsenyi
force-pushed
the
service-layer
branch
from
2af6d13 to
d7eba10
Compare
palkerecsenyi
force-pushed
the
service-layer
branch
from
ae94e9c to
0aedde2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
Created a new VCSService class to act as the 'glue' between the new generic provider API methods and the view handlers, with mostly higher-level methods that combine multiple API calls and reads/writes to the DB.
Also included the modified VCSRelease class in the same file. This has been kept to maintain good compatibility with InvenioRDM and anyone else who might have overriden it. However, it has been updated to support the new generic structure. There have also been some small changes such as the variable naming (
release_objectandrelease_payloadtodb_releaseandgeneric_releaseto make more clear where the data comes from).The OAuth handlers, tasks, and webhook receivers are also updated as part of this PR, again with small changes to make them compatible with the generic structure.
This commit on its own is UNRELEASABLE. We will merge multiple commits related to the VCS upgrade into the
vcs-stagingbranch and then merge them all intomasteronce we have a fully release-ready prototype. At that point, we will create a squash commit.