Closed
Conversation
nakshatris
commented
May 23, 2025
|
|
||
|
|
||
| <dependencies> | ||
| <dependency> |
Collaborator
Author
There was a problem hiding this comment.
@Zakaria-Kofiro : do we need this?
I see it in your PR, but I couldn't find a real need.
Collaborator
There was a problem hiding this comment.
Not needed - part of setting up a new central reporting module (CW, S3)
Collaborator
|
This PR appear to remove the files that send call performance metrics.
|
Collaborator
Author
|
After discussion with @kevin-mcgoldrick , I will be keeping the reporting module as-is to avoid risking removing important required files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the required files from reporting module under api, and removed the reporting module.
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **