Skip to content

Conversation

@xabg2
Copy link
Collaborator

@xabg2 xabg2 commented Oct 3, 2025

This PR implements a new command in the CLI folder to be able to sync the user with their tier in Drive.

By passing the business parameter, it will be sync the business subscriptions. By default it syncs the Individual ones (subscription/lifetime).

⚠️ This PR requires a new env variable called: X_INTERNXT_PAYMENTS_HEADER

@xabg2 xabg2 requested a review from apsantiso October 3, 2025 08:32
@xabg2 xabg2 self-assigned this Oct 3, 2025
@xabg2 xabg2 added the enhancement New feature or request label Oct 3, 2025
apsantiso
apsantiso previously approved these changes Oct 7, 2025
@apsantiso apsantiso requested review from apsantiso October 7, 2025 09:12
Base automatically changed from feat/update-the-user-tier-in-drive to master October 7, 2025 09:39
@xabg2 xabg2 dismissed apsantiso’s stale review October 7, 2025 09:39

The base branch was changed.

@xabg2 xabg2 marked this pull request as ready for review October 7, 2025 10:06
@xabg2 xabg2 requested a review from sg-gs as a code owner October 7, 2025 10:06
$project: {
_id: 0,
userUuid: '$user.uuid',
foreignTierId: '$tier.foreignTierId',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this working if foreignTierId is inside tier.drive field?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. It should be tier.featuresPerService.drive.foreignTierId. Nice catch! 🚀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Coverage on New Code (required ≥ 85%)
15.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions
Copy link

⚠️ This pull request has been marked as stale due to 30 days of inactivity.

It will be automatically closed in 7 days if no further updates are made.

@github-actions github-actions bot added the stale No activity for a while. Needs attention. label Oct 24, 2025
@github-actions
Copy link

❌ This pull request has been automatically closed due to prolonged inactivity.

@github-actions github-actions bot added the auto-closed The pull request has been closed automatically by repository rules. label Nov 24, 2025
@github-actions github-actions bot closed this Nov 24, 2025
@xabg2 xabg2 reopened this Dec 16, 2025
@xabg2 xabg2 marked this pull request as draft December 16, 2025 09:59
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Coverage on New Code (required ≥ 85%)
15.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions github-actions bot removed the auto-closed The pull request has been closed automatically by repository rules. label Dec 17, 2025
@xabg2 xabg2 marked this pull request as ready for review January 22, 2026 09:09
@xabg2 xabg2 requested a review from jzunigax2 as a code owner January 22, 2026 09:09
@xabg2 xabg2 requested a review from sg-gs January 22, 2026 09:09
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.6% Coverage on New Code (required ≥ 85%)
11.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

customHeaders?: Record<string, string>;
}): Promise<void> {
const jwt = signToken('5m', this.config.DRIVE_NEW_GATEWAY_SECRET);
let totalMaxSpaceBytes: number | undefined = undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

let totalMaxSpaceBytes = maxSpaceBytes;

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space can be undefined because we can update the customer only by using the tierId.

@github-actions github-actions bot removed the stale No activity for a while. Needs attention. label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready-for-preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants