[PB-5566]: fix/prevent DOM removal crash caused by browser translation #1828
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying drive-web with
|
| Latest commit: |
56c65d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2fd85291.drive-web.pages.dev |
| Branch Preview URL: | https://fix-avoid-removing-the-ifram.drive-web.pages.dev |
|
larryrider
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the browser’s built-in translation feature is enabled, it mutates the DOM after the initial render. This can cause React to lose track of its internal node references and trigger a
NotFoundError: Failed to execute 'removeChild'in Edge, leaving the app in a broken state.This PR introduces a defensive patch that guards against invalid
removeChildcalls by ensuring the node is still a child of its parent before attempting removal. This prevents crashes caused by browser translation tools while preserving the expected application behavior.Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes