[PB-3520]: migrate Popover components from @headlessui/react to custom wrapper #1826
+223
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m wrapper Replace direct @headlessui/react Popover usage with unified custom Popover component across ShareDialog, UserOptions, and AccountPopover components. Changes: - Update ShareDialog to use custom Popover with render props pattern - Refactor UserOptions to use custom Popover with alwaysShow prop - Simplify AccountPopover panel prop usage (remove wrapper function) - Consolidate Popover API across all components for consistency The custom Popover maintains HeadlessUI functionality while providing a simpler, more flexible API with support for advanced patterns like render props and controlled visibility.
terrerox
changed the title
Deploying drive-web with
|
| Latest commit: |
e4abcdd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5f10a3f6.drive-web.pages.dev |
| Branch Preview URL: | https://feature-popover-ui.drive-web.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace direct @headlessui/react Popover usage with unified custom Popover component
across ShareDialog, UserOptions, and AccountPopover components.
Changes:
The custom Popover maintains HeadlessUI functionality while providing a simpler,
more flexible API with support for advanced patterns like render props and
controlled visibility.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes