[PB-5542]: Add file version history locked feature modal #1808
+236
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a locked feature modal to inform users about version restoration capabilities in paid plans. - Updated i18n translations for the new locked feature. - Refactored file version service imports and related tests. - Enhanced version history menu configuration to handle locked states. - Implemented dropdown positioning hook for better UI interactions. - Added tests for version item actions and dropdown positioning. - Integrated version limits fetching in the PlansSection for better user experience.
7 tasks
Deploying drive-web with
|
| Latest commit: |
4315ad2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://751fe0df.drive-web.pages.dev |
| Branch Preview URL: | https://feature-file-version-history-8eiq.drive-web.pages.dev |
Base automatically changed from
feature/file-version-history-v2
to
feature/file-version-history
January 10, 2026 04:17
- Add downloadName option to DownloadItem type to support custom filenames - Update downloadWorkerHandler to accept and use custom download names - Format version download filenames as "(DD-MM-YYYY at HH:mm) filename.ext" - Use dateService and itemsUtils from @internxt/lib for proper formatting - Pass custom filename through downloadOptions instead of modifying item name
CandelR
reviewed
Jan 12, 2026
Comment on lines
9
to
12
| const MODAL_DIMENSIONS = { | ||
| width: '282px', | ||
| height: '333px', | ||
| } as const; |
Collaborator
There was a problem hiding this comment.
The modal has to have this fixed sizes?
Contributor
Author
There was a problem hiding this comment.
Yes, since it’s inside the file, the version sidebar will not have any issues on smaller screens
| if (item.isFolder) { | ||
| return item.name; | ||
| } | ||
| return item.type ? `${item.name}.${item.type}` : item.name; |
Collaborator
There was a problem hiding this comment.
Will the name never include the extension?
Contributor
Author
There was a problem hiding this comment.
No, the name/plainName does not include the extension, it's stored separately in the type field.
| <div className="absolute inset-0 z-10 flex items-center justify-center bg-black/10 dark:bg-black/30 backdrop-blur-[3px]"> | ||
| <div | ||
| className="mx-6 flex max-w-xs flex-col items-center gap-4 rounded-2xl border border-gray-10 bg-surface pt-6 dark:border-gray-5 dark:bg-gray-1" | ||
| style={MODAL_DIMENSIONS} |
Collaborator
There was a problem hiding this comment.
nit: Whenever possible, use classes instead of inline styles
CandelR
approved these changes
Jan 13, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a locked feature modal for file version history when versioning
is not enabled, prompting users to upgrade to access the feature.
Changes:
Refactor:
(upgrade flow now handled in context menu and Sidebar)
Translations:
(en, es, fr, de, it, ru, zh, tw)
Tests:
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes