Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where setting preferenceDepthHops = 0 (intended to enable depth first crawling) caused Heritrix to reject seed URLs immediately with fetch status -50.
The problem was in TooManyHopsDecideRule, where a negative maxHops value (used internally for DFS) caused all URIs including seeds with hop count 0 to be evaluated as exceeding the hop limit. As a result, no crawling occurred.
The fix updates the hop limit evaluation logic to:
Treat negative maxHops values as “no hop limit”
Always allow seed URLs (hopCount == 0) to pass the rule
This restores the documented DFS behavior while preserving existing behavior for normal breadth first crawls.