Avoid reading global Git configuration #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beanieboi
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a global Git configuration file which sets
diff.noPrefixto false. This meansgit diffwon't producea/andb/prefixes for changed paths.This breaks an assumption in one of the tests:
pliny/spec/commands/updater_spec.rb
Line 29 in 3641a44
There's a lot of settings that may potentially cause Git to behave differently so I'm using the
GIT_CONFIG_GLOBALenvironment variable to prevent ever reading the user's configuration.(I'm not making a note in the changeling as this both seems below the line in terms of importance and shouldn't matter to anyone who isn't contributing to Pliny itself.)