Fix generation of min/max calls for SYCL#212
Merged
aneshlya merged 1 commit intointel:mainfrom Jul 11, 2025
Merged
Conversation
SYCL 2020 specification does not define min/max overloads accepting `bool` data type, but yarpgen generates code that calls them. Of course, such code does not compile and to fix this, we do a promotion from `bool` to `char` (or `signed char`, to be precise). Signed-off-by: Alexey Sachkov <alexey.sachkov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYCL 2020 specification does not define min/max overloads accepting
booldata type, but yarpgen generates code that calls them. Of course, such code does not compile and to fix this, we do a promotion frombooltochar(orsigned char, to be precise).