Skip to content

Policy v2: skip global types for rebinding #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haitaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Policy v2: skip global types for rebinding #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions src/migtd/src/mig_policy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,16 @@ mod v2 {
let relative_reference = get_local_tcb_evaluation_info()?;
let policy = get_verified_policy().ok_or(PolicyError::InvalidParameter)?;

policy
.policy_data
.evaluate_policy_common(&evaluation_data_dst, &relative_reference)?;
policy
.policy_data
.evaluate_policy_forward(&evaluation_data_dst, &relative_reference)?;
policy.policy_data.evaluate_policy_common(
&evaluation_data_dst,
&relative_reference,
false,
)?;
policy.policy_data.evaluate_policy_forward(
&evaluation_data_dst,
&relative_reference,
false,
)?;

// Verify the destination's policy against local policy
verified_policy_dst
Expand All @@ -218,9 +222,11 @@ mod v2 {
let relative_reference = get_local_tcb_evaluation_info()?;
let policy = get_verified_policy().ok_or(PolicyError::InvalidParameter)?;

policy
.policy_data
.evaluate_policy_backward(&evaluation_data_src, &relative_reference)?;
policy.policy_data.evaluate_policy_backward(
&evaluation_data_src,
&relative_reference,
false,
)?;

Ok(suppl_data)
}
Expand All @@ -242,9 +248,11 @@ mod v2 {
let relative_reference = get_local_tcb_evaluation_info()?;
let policy = get_verified_policy().ok_or(PolicyError::InvalidParameter)?;

policy
.policy_data
.evaluate_policy_forward(&evaluation_data_dst, &relative_reference)?;
policy.policy_data.evaluate_policy_forward(
&evaluation_data_dst,
&relative_reference,
true,
)?;

// Verify the destination's policy against local policy
verified_policy_dst
Expand Down Expand Up @@ -299,15 +307,19 @@ mod v2 {

let relative_reference =
get_init_tcb_evaluation_info(&init_tdreport, &verified_policy_init)?;
policy
.policy_data
.evaluate_policy_common(&evaluation_data_src, &relative_reference)?;
policy.policy_data.evaluate_policy_common(
&evaluation_data_src,
&relative_reference,
true,
)?;

// If backward policy exists, evaluate the migration src based on it.
let relative_reference = get_local_tcb_evaluation_info()?;
policy
.policy_data
.evaluate_policy_backward(&evaluation_data_src, &relative_reference)?;
policy.policy_data.evaluate_policy_backward(
&evaluation_data_src,
&relative_reference,
true,
)?;

Ok(tdx_report.as_bytes().to_vec())
}
Expand Down
21 changes: 17 additions & 4 deletions src/policy/src/v2/policy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,12 @@ impl<'a> PolicyData<'a> {
&self,
value: &PolicyEvaluationInfo,
relative_reference: &PolicyEvaluationInfo,
skip_global: bool,
) -> Result<(), PolicyError> {
match self.forward_policy.as_ref() {
Some(policy) => Self::evaluate_policy_block(policy, value, relative_reference),
Some(policy) => {
Self::evaluate_policy_block(policy, value, relative_reference, skip_global)
}
None => Ok(()),
}
}
Expand All @@ -309,9 +312,12 @@ impl<'a> PolicyData<'a> {
&self,
value: &PolicyEvaluationInfo,
relative_reference: &PolicyEvaluationInfo,
skip_global: bool,
) -> Result<(), PolicyError> {
match self.backward_policy.as_ref() {
Some(policy) => Self::evaluate_policy_block(policy, value, relative_reference),
Some(policy) => {
Self::evaluate_policy_block(policy, value, relative_reference, skip_global)
}
None => Ok(()),
}
}
Expand All @@ -320,9 +326,12 @@ impl<'a> PolicyData<'a> {
&self,
value: &PolicyEvaluationInfo,
relative_reference: &PolicyEvaluationInfo,
skip_global: bool,
) -> Result<(), PolicyError> {
match self.policy.as_ref() {
Some(policy) => Self::evaluate_policy_block(policy, value, relative_reference),
Some(policy) => {
Self::evaluate_policy_block(policy, value, relative_reference, skip_global)
}
None => Ok(()),
}
}
Expand All @@ -331,11 +340,15 @@ impl<'a> PolicyData<'a> {
block: &Vec<PolicyTypes>,
value: &PolicyEvaluationInfo,
relative_reference: &PolicyEvaluationInfo,
skip_global: bool,
) -> Result<(), PolicyError> {
for policy_type in block {
match policy_type {
PolicyTypes::Global(global) => global.evaluate(value, relative_reference)?,
PolicyTypes::Global(global) if !skip_global => {
global.evaluate(value, relative_reference)?
}
PolicyTypes::Servtd(migtd) => migtd.evaluate(value, relative_reference)?,
_ => {}
}
}
Ok(())
Expand Down
Loading