Skip to content

MigTD: Add trace-level logs for request entry points #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jyao1 merged 1 commit into from
Feb 24, 2026
Merged

MigTD: Add trace-level logs for request entry points #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/migtd/src/bin/migtd/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,7 @@ fn handle_pre_mig() {
{
match request {
WaitForRequestResponse::StartMigration(wfr_info) => {
log::trace!(migration_request_id = wfr_info.mig_info.mig_request_id; "Processing StartMigration request\n");
let status = exchange_msk(&wfr_info)
.await
.map(|_| MigrationResult::Success)
Expand Down Expand Up @@ -450,6 +451,7 @@ fn handle_pre_mig() {
WaitForRequestResponse::StartRebinding(rebinding_info) => {
use migtd::migration::rebinding::start_rebinding;

log::trace!(migration_request_id = rebinding_info.mig_request_id; "Processing StartRebinding request\n");
let status = start_rebinding(&rebinding_info, &mut data)
.await
.map(|_| MigrationResult::Success)
Expand Down Expand Up @@ -480,6 +482,7 @@ fn handle_pre_mig() {
REQUESTS.lock().remove(&rebinding_info.mig_request_id);
}
WaitForRequestResponse::GetTdReport(wfr_info) => {
log::trace!(migration_request_id = wfr_info.mig_request_id; "Processing GetTdReport request\n");
let status = get_tdreport(
&wfr_info.reportdata,
&mut data,
Expand All @@ -499,6 +502,7 @@ fn handle_pre_mig() {
REQUESTS.lock().remove(&wfr_info.mig_request_id);
}
WaitForRequestResponse::EnableLogArea(wfr_info) => {
log::trace!(migration_request_id = wfr_info.mig_request_id; "Processing EnableLogArea request\n");
let status = enable_logarea(
wfr_info.log_max_level,
wfr_info.mig_request_id,
Expand Down Expand Up @@ -532,6 +536,7 @@ fn handle_pre_mig() {
}
#[cfg(feature = "policy_v2")]
WaitForRequestResponse::GetMigtdData(wfr_info) => {
log::trace!(migration_request_id = wfr_info.mig_request_id; "Processing GetMigtdData request\n");
let status = get_migtd_data(
&wfr_info.reportdata,
&mut data,
Expand Down
1 change: 1 addition & 0 deletions src/migtd/src/migration/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ pub async fn wait_for_request() -> Result<WaitForRequestResponse> {
}

let operation: u8 = data_status_bytes[1];
log::trace!("wait_for_request: Received operation {} with data length {}\n", operation, data_length);
if operation == DataStatusOperation::StartMigration as u8 {
// data_length should be MigtdMigrationInformation
let expected_datalength = size_of::<MigtdMigrationInformation>();
Expand Down
Loading