Skip to content

Conversation

@Gregocact
Copy link
Contributor

Modified lcc25.py to make the script match the stepsize of the instrument LCC25 by modifying the associated f-string.

@scasagrande
Copy link
Contributor

looks like I have something to fix first, probably a dependency that updated....

@Gregocact
Copy link
Contributor Author

I am not sure what happened. The diff is just 5 instances of changing a 1 for a 3. I suspect it is because I tried to make pr from a computer where I have to use windows store python and pre-commit has problems with that. I will try the PR from my Linux machine tomorrow

@scasagrande
Copy link
Contributor

can you try merging the latest main into your branch?

@scasagrande
Copy link
Contributor

perfect, now the errors are actual test failures related to your change.

@Gregocact
Copy link
Contributor Author

I updated the test to reflect the change to the instrument resolution.

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (1be7d8a) to head (d508200).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          95       95           
  Lines        9596     9596           
=======================================
  Hits         9519     9519           
  Misses         77       77           
Flag Coverage Δ
unittests 99.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@scasagrande scasagrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch!

@scasagrande scasagrande merged commit 3885be0 into instrumentkit:main Sep 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants