fix: use different level for skipped schemas#296
Open
jstrachan wants to merge 3 commits intoinstrumenta:masterfrom
Open
fix: use different level for skipped schemas#296jstrachan wants to merge 3 commits intoinstrumenta:masterfrom
jstrachan wants to merge 3 commits intoinstrumenta:masterfrom
Conversation
lets not use the same warning level for skipped schemas as we do for actual validation errors so that its easy to tell the output difference between actual schema validation errors versus CRD kinds that are skipped
so we can hide PASS/INFO level logs to just see the warnings only if you are validating lots of files
so that the real file name is used in error reporting
|
+1 for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lets not use the same warning level for skipped schemas as we do for actual validation errors
so that its easy to tell the output difference between actual schema validation errors versus CRD kinds that are skipped
e.g. you can easily grep the output for
WARNversusINFOto see the difference between skipped kinds versus actual schema errors