[Feature] - Ajoute le support de la base des lieux de naissance#31
Merged
[Feature] - Ajoute le support de la base des lieux de naissance#31
Conversation
Xusifob
requested changes
Mar 27, 2025
Member
Xusifob
left a comment
Xusifob
left a comment
There was a problem hiding this comment.
La recherche marche bien, j'ai pris ces 2 exemples :
Saint-Jean-le-Priche, Loché, et Sennecé-lès-Mâcon ont fusionné avec Mâcon le 1er juillet 1972. Ces communes sont devenues des communes associées de Mâcon, sans que leurs noms apparaissent dans le nom de la nouvelle entité 12.
Targé a fusionné avec Châtellerault le 1er juin 1972. Targé est devenue une commune associée de Châtellerault, et son nom n'apparaît pas dans le nom de la nouvelle commune 12.
Pas mal de retours sur la forme
Comment on lines
+75
to
+79
| $communeFilePath = __DIR__ . '/../../data/insee/v_commune_2024.csv'; | ||
| $commune1943FilePath = __DIR__ . '/../../data/insee/v_commune_depuis_1943.csv'; | ||
| $communeEventFilePath = __DIR__ . '/../../data/insee/v_mvt_commune_2024.csv'; | ||
| $paysFilePath = __DIR__ . '/../../data/insee/v_pays_territoire_2024.csv'; | ||
| $pays1943FilePath = __DIR__ . '/../../data/insee/v_pays_et_territoire_depuis_1943.csv'; |
Member
There was a problem hiding this comment.
Pour le coup, ces fichiers vont évoluer, donc il faut aller les download directement sur le site de l'ANS, et pas les importer comme ça
Xusifob
force-pushed
the
feature/ins-birthplace
branch
from
2155ebb to
d1d85e8
Compare
Xusifob
force-pushed
the
feature/ins-birthplace
branch
from
0fd6a30 to
af57af4
Compare
Xusifob
changed the title
Xusifob
pushed a commit
that referenced
this pull request
May 14, 2025
* import INSEE * make lint * add birthplace api endpoint * fix search * PR fix * fix * fix * fix * fix * update fixtures --------- Co-authored-by: Bastien Malahieude <malahieude@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️
https://www.notion.so/instamed/INS-Lieu-de-naissance-1b4503fffdf180fcb3d9c21d4a17a3aa
https://www.notion.so/instamed/Section-type-1-General-Information-16d503fffdf18028a95cdf2ed50dd187
📜
php bin/console app:insee:import -vvPurge option to re-run from fresh import ( delete the 5 table)
php bin/console app:insee:import --purge --force -vvOption to import only one file
php bin/console app:insee:import -vv --target=commune1943Values are : "commune","commune1943","event","pays","pays1943" or "all". default to "all"