Enable R8 optimizations. #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
force-pushed
the
laimonas/r8-tests
branch
3 times, most recently
from
a2fd5a5 to
5cafdb7
Compare
JaCoCo Code Coverage 93.98% ✅
Generated by 🚫 Danger |
📊 Benchmark Comparison ReportSummary
No significant changes (25 benchmarks)
Regression threshold: ±10% with non-overlapping confidence intervals Generated by 🚫 Danger |
Laimiux
force-pushed
the
laimonas/r8-tests
branch
from
5cafdb7 to
5e79884
Compare
Laimiux
commented
Dec 2, 2025
| @@ -0,0 +1,72 @@ | |||
| name: R8 Integration Tests | |||
Collaborator
Author
There was a problem hiding this comment.
Running emulator tests on github CI
Laimiux
force-pushed
the
laimonas/r8-tests
branch
2 times, most recently
from
24062b9 to
fc5e784
Compare
Laimiux
commented
Dec 2, 2025
|
|
||
| object AbstractClassInheritanceFormulas { | ||
|
|
||
| class One : ActionFormula<Unit, Int>() { |
Collaborator
Author
There was a problem hiding this comment.
Both One and Two extend ActionFormula. In our test, we want to make sure that IFormula.type() implementation is not modified by R8.
Collaborator
Author
There was a problem hiding this comment.
This was the primary issue that I noticed with fullMode=true enabled
Laimiux
force-pushed
the
laimonas/r8-tests
branch
2 times, most recently
from
bf0dcf7 to
1587859
Compare
Laimiux
commented
Dec 2, 2025
| @@ -0,0 +1,70 @@ | |||
| plugins { | |||
Collaborator
Author
There was a problem hiding this comment.
Configuring tests with R8 enabled
Laimiux
commented
Dec 2, 2025
| @@ -0,0 +1,9 @@ | |||
| # Formula R8/ProGuard Rules | |||
Collaborator
Author
There was a problem hiding this comment.
This will be packaged with the jar. Without this, the test fails with
com.instacart.formula.r8.FormulaR8Test > actionFormulas[Medium_Phone_API_36.1(AVD) - 16] FAILED
R.a: Formula class S.a with a key FormulaKey(scopeKey=null, type=class S.a, key=kotlin.Unit) already requested by class com.instacart.formula.r8.interactors.AbstractFormulaTypeInheritanceInteractor$formula$1
at Q.e.a(SourceFile:74)
Tests on Medium_Phone_API_36.1(AVD) - 16 failed: There was 1 failure(s).
Laimiux
force-pushed
the
laimonas/r8-tests
branch
from
1587859 to
a4d9eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding official support for R8 optimizations for formula