Add i18n support #108
Open
Add i18n support #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm afraid this is too much for us to review (and maintain) right now. We will have to evaluate if there are other localization libraries that are a better fit (transloco, ngx-translate, classic PO -based ...), and I'm not a fan of the massive autogenerated XML files. I will prefer to keep this in the back burner until we have time to research it more, and maybe we have more languages available, and translators committed to keep the translations updated. Thanks for your contribution, let's keep the PR open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
https://ctrl.853lab.com/en-US/https://ctrl.853lab.com/zh-CN/
https://ctrl-i18n.pages.dev/
https://ctrl-i18n.pages.dev/en-US/
https://ctrl-i18n.pages.dev/zh-CN/
I mistakenly closed pull request #84 . And the "_redirects" file needs to be verified to be available.