Skip to content

"AT-716: Update Inpsyde in code to Syde (license, copyright, text)" #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
overclokk merged 2 commits into from
Jan 27, 2025
Merged

"AT-716: Update Inpsyde in code to Syde (license, copyright, text)" #6

overclokk merged 2 commits into from
Jan 27, 2025

Conversation

@overclokk
Copy link
Contributor

@overclokk overclokk commented Jan 20, 2025

No description provided.

@overclokk overclokk requested review from Chrico, gmazzap and tyrann0us and removed request for Chrico and gmazzap January 20, 2025 08:48
tyrann0us
tyrann0us approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please check and ideally fix the Psalm error in CommentsDisabler.php according to the Boy Scout rule? Thank you!

@overclokk
Copy link
Contributor Author

overclokk commented Jan 20, 2025 •
edited
Loading

Hi @tyrann0us yes, you're right, but the problem is that I need to update hundreds of repository so at the momento I have no time to also check for GHA failures, I think for this it is better to open a ticket or something else, in any case I'll add this also in the ticket I'm working.

@tyrann0us
fix: remove unnecessary check
6ae5cb3 
`get_post_types()` returns an array of post type identifiers, and post type slugs are always strings.

Signed-off-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
@tyrann0us
Copy link
Member

tyrann0us commented Jan 21, 2025

Hi @tyrann0us yes, you're right, but the problem is that I need to update hundreds of repository so at the momento I have no time to also check for GHA failures, I think for this it is better to open a ticket or something else, in any case I'll add this also in the ticket I'm working.

Understandable. I have removed the offending and unnecessary check.

@overclokk
Copy link
Contributor Author

overclokk commented Jan 21, 2025

@tyrann0us ok, if it is ok for you I can merge.

@tyrann0us
Copy link
Member

tyrann0us commented Jan 22, 2025

@tyrann0us ok, if it is ok for you I can merge.

Yes, please. 🙂

@overclokk overclokk merged commit 4f24bfe into main Jan 27, 2025
10 checks passed
@overclokk overclokk deleted the AT-716 branch January 27, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyrann0us tyrann0us tyrann0us approved these changes

@Chrico Chrico Awaiting requested review from Chrico

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overclokk @tyrann0us