give the body direct access to its sink writer #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We normally indirectly gain access to the writer in two ways: one is through the `when_ready_to_write` callback, and the other through `transfer_to_writer` as an argument. Instead, just give the writer to the body writer directly but continue to drive it from the outside. This is mostly a simple refactor, but it gives us the ability to do something smarter in another branch, which is to query the writer to see if a flush will succeed or not and report back to the user so they can act appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We normally indirectly gain access to the writer in two ways: one is
through the
when_ready_to_writecallback, and the other throughtransfer_to_writeras an argument. Instead, just give the writer tothe body writer directly but continue to drive it from the outside.
This is mostly a simple refactor, but it gives us the ability to do
something smarter in another branch, which is to query the writer to see
if a flush will succeed or not and report back to the user so they can
act appropriately.