Add pot action 2 #69
Add pot action 2 #69
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: odoo-19/partner_sales_abc Translate-URL: https://hosted.weblate.org/projects/odoo-19/partner_sales_abc/es/
Currently translated at 100.0% (3 of 3 strings) Translation: odoo-19/partner_sales_abc Translate-URL: https://hosted.weblate.org/projects/odoo-19/partner_sales_abc/es/
Add workflow to update .pot files on push to specific branches
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the partner_sales_abc Odoo module from version 13.0 to version 18.0, implementing a field to track ABC sales classification for partners.
- Uncommented and activated the models import to enable the new
abc_sales_amountfield on partners - Added a new field to the partner form view within the sales/purchases section for ABC sales classification
- Updated translation files and workflow configuration for Odoo 18.0 compatibility
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| partner_sales_abc/init.py | Uncommented the models import to enable the new partner extension |
| partner_sales_abc/manifest.py | Updated module version from 13.0 to 18.0 and changed dependency from commented base/mail to contacts |
| partner_sales_abc/models/init.py | Added init file to import the res_partner model extension |
| partner_sales_abc/models/res_partner.py | Added partner model extension with abc_sales_amount field |
| partner_sales_abc/views/partner_view.xml | Added form view inheritance to display ABC classification group in sales/purchases page |
| partner_sales_abc/i18n/es.po | Updated Spanish translation file for Odoo 18.0 |
| partner_sales_abc/i18n/fr.po | Updated POT creation date in French translation file |
| partner_sales_abc/i18n/pt.po | Removed Portuguese translation file |
| partner_sales_abc/i18n/partner_sales_abc.pot | Removed old POT template file |
| .github/workflows/update_pot_files.yml | Added GitHub workflow for automated POT file updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <page name="sales_purchases"> | ||
| <group name="clasificacion_abc" string="Clasificacion ABC"> | ||
| <field name="abc_sales_amount"/> | ||
| </group> | ||
| </page> |
There was a problem hiding this comment.
The XPath selector references page name="sales_purchases" without specifying a position attribute. According to Odoo XML inheritance best practices, you should explicitly specify the position attribute (e.g., position="inside") to make the inheritance behavior clear and predictable.
| <page name="sales_purchases"> | |
| <group name="clasificacion_abc" string="Clasificacion ABC"> | |
| <field name="abc_sales_amount"/> | |
| </group> | |
| </page> | |
| <xpath expr="//page[@name='sales_purchases']" position="inside"> | |
| <group name="clasificacion_abc" string="Clasificacion ABC"> | |
| <field name="abc_sales_amount"/> | |
| </group> | |
| </xpath> |
partner_sales_abc/i18n/es.po
Outdated
| #: model_terms:ir.ui.view,arch_db:partner_sales_abc.view_partner_user_form | ||
| msgid "Clasificacion ABC" | ||
| msgstr "Clasificacion ABC" | ||
| msgstr "" |
There was a problem hiding this comment.
The translation for "Clasificacion ABC" was removed (changed from "Clasificacion ABC" to empty string ""). This will leave the Spanish translation incomplete. If this was intentional to regenerate translations, ensure the POT files are updated correctly. Otherwise, restore the translation value.
| msgstr "" | |
| msgstr "Clasificación ABC" |
| <field name="inherit_id" ref="base.view_partner_form"/> | ||
| <field name="arch" type="xml"> | ||
| <page name="sales_purchases"> | ||
| <group name="clasificacion_abc" string="Clasificacion ABC"> |
There was a problem hiding this comment.
Spelling error: "Clasificacion" should be "Clasificación" (missing accent on the 'o').
| <group name="clasificacion_abc" string="Clasificacion ABC"> | |
| <group name="clasificacion_abc" string="Clasificación ABC"> |
| jobs: | ||
| update-pot: | ||
| runs-on: ubuntu-22.04 | ||
| container: ghcr.io/oca/oca-ci/py3.10-odoo17.0:latest |
There was a problem hiding this comment.
Version mismatch: The workflow uses py3.10-odoo17.0:latest container, but the module manifest indicates version 18.0 (partner_sales_abc/__manifest__.py line 22). This mismatch may cause compatibility issues during POT file generation. Consider updating to use py3.10-odoo18.0:latest or the appropriate Odoo 18 container.
| container: ghcr.io/oca/oca-ci/py3.10-odoo17.0:latest | |
| container: ghcr.io/oca/oca-ci/py3.10-odoo18.0:latest |
No description provided.