chore: remove unnecessary deepcopy()s and use sets instead of lists #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdstrand
force-pushed
the
jdstrand/perf-fixes
branch
from
1e4d9a9 to
c283f39
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary copy.deepcopy() calls and optimizes data structures by using sets instead of lists where appropriate. The changes improve performance and code clarity without altering functionality.
Changes:
- Replaced
copy.deepcopy()with shallow copies or direct references where deep copying was unnecessary - Converted list-based URL collection to use sets for automatic duplicate handling and improved performance
- Simplified return values in
collectGHAlertUrlsto directly return sets instead of converting from lists
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cvelib/cve.py | Removed unnecessary deepcopy of CVE packages list and CVE object; optimized collectGHAlertUrls to use sets instead of lists for URL tracking |
| cvelib/common.py | Removed redundant deepcopy calls in readFile and readCve functions that were copying newly created objects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.