refactor: Preparatory cahnges for polymorphic labels #4393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockstar
approved these changes
Jan 11, 2022
Contributor
rockstar
left a comment
rockstar
left a comment
There was a problem hiding this comment.
Looking at the individual commits was helpful for context. Thanks for making that suggestion.
added 3 commits
January 12, 2022 12:08
Instead of assuming they share the `consequent` type.
Marwes
force-pushed
the
refactor_more
branch
2 times, most recently
from
2439772 to
05f1050
Compare
added 3 commits
January 12, 2022 13:30
Using variables here causes some tests to change occasionally when changes to the semantic graph changes how many `fresh()` calls we do. Since we usually do not use these variables we can instead call `fresh()` when we actually need it during inference instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of commits extracted from #4388 which could be merged independently. See individual commits.