Implement GWBK Stats for 8.3#320
Open
Joshlha wants to merge 1 commit intoinductiveautomation:mainfrom
Open
Conversation
| package io.github.inductiveautomation.kindling.statistics.config83 | ||
|
|
||
| @Suppress("unused") | ||
| enum class PlatformResourceCategory { |
Member
There was a problem hiding this comment.
I think this resource building stuff isn't quite right.
While I don't want to literally re-use the core Ignition types/dependencies, the way we're building things up here isn't quite correct and I think especially might cause some headaches if we ever start doing richer project parsing.
I've got some staged work on a branch I might be able to revive over the holidays to make some tweaks to this PR; we'll see.
Collaborator
Author
There was a problem hiding this comment.
Part of the problem is that I've got no idea how it works in Ignition. The other part of the problem is that I've got zero experience doing this kind of thing, so this is what you'd called a good ol' college try.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new actual features added. Just added support to show the same statistics for 8.3 gateway backups that we were already showing for 7.9-8.1.
Obviously open to critiques for the implementation choices I made. I tried to keep the code reusable and relevant to this PR while future proofing us for potentially adding more features related to 8.3 resources in the future.