Skip to content

Conversation

@majosm
Copy link
Collaborator

@majosm majosm commented Jul 7, 2025

Want to use in inducer/meshmode#467 (code).

@majosm majosm requested a review from inducer July 7, 2025 17:59
@inducer
Copy link
Owner

inducer commented Jul 7, 2025

Not super opposed to this, but is it needed? Couldn't you just

import pytato.loopy as pt_lp

or so? What type of (I assume) bpr complaint are you seeing?

@majosm
Copy link
Collaborator Author

majosm commented Jul 7, 2025

Not super opposed to this, but is it needed? Couldn't you just

import pytato.loopy as pt_lp

or so? What type of (I assume) bpr complaint are you seeing?

Yeah, that would be fine too. It just seemed like an inconsistency, since I can already do pt.function., pt.transform., etc.

The errors I see are:

/home/runner/work/meshmode/meshmode/meshmode/array_context.py:267:33 - warning: Type of "loopy" is unknown (reportUnknownMemberType)
Warning: Type of "loopy" is unknown (reportUnknownMemberType)
/home/runner/work/meshmode/meshmode/meshmode/array_context.py:267:33 - warning: Type of "LoopyCallResult" is unknown (reportUnknownMemberType)
Warning: Type of "LoopyCallResult" is unknown (reportUnknownMemberType)
/home/runner/work/meshmode/meshmode/meshmode/array_context.py:267:36 - error: "loopy" is not a known attribute of module "pytato" (reportAttributeAccessIssue)
Error: "loopy" is not a known attribute of module "pytato" (reportAttributeAccessIssue)

@majosm
Copy link
Collaborator Author

majosm commented Jul 7, 2025

As discussed, switching to import pytato.loopy as pt_lp in meshmode instead.

@majosm majosm closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants