-
Notifications
You must be signed in to change notification settings - Fork 16
Enable duplication checks by default #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable duplication checks by default #614
Conversation
2dcf277 to
76ef440
Compare
76ef440 to
485ed49
Compare
a7a4501 to
1802263
Compare
|
#616 should clean up some of the bpr nonsense. |
1802263 to
ee7709e
Compare
|
Note to self: These should probably be |
ee7709e to
30d3321
Compare
30d3321 to
5bf59af
Compare
|
@inducer I looked into what specifically was making the mapper-created duplicate check in I also took a stab at caching equality for mapper cache dict lookups here, but at least with my implementation it didn't show any benefit (number of equality |
5bf59af to
b2845b3
Compare
b2845b3 to
12f37d3
Compare
inducer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM subject to:
- Let's defer
sortedremoval until we're onconstantdict
41fa277 to
8545054
Compare
8545054 to
624657b
Compare
624657b to
dcbfdb2
Compare
Duplication checks have been off by default due to some subpackages still having code that duplicates. Now that inducer/arraycontext#221 has been merged, it may be possible to enable the checks by default. Likely there are still a few spots in arraycontext/meshmode/grudge (and the production versions of those) that need fixing, but hopefully they should be minor.
Draft because:
_dag_to_compiled_funcarraycontext#324 and Avoid duplication inPytatoJAXArrayContext.freezearraycontext#325untag_loopy_call_resultsmeshmode#467_dag_to_compiled_funcgrudge#384