Add duplicate node counter functionality and tests #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@majosm Please review when convenient! |
inducer
reviewed
Jul 15, 2024
Owner
Contributor
Author
|
Sounds good, I'll fix those errors today. Thank you! |
Co-authored-by: Matt Smith <mjsmith1@gmail.com>
Collaborator
|
How's this look @inducer? |
inducer
reviewed
Jul 29, 2024
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! Almost looks good, not far now. 👍
| return ncm.expr_type_counts | ||
|
|
||
|
|
||
| def get_num_nodes( |
Owner
There was a problem hiding this comment.
This breaks compatibility (= True would retain compatibility).
Maybe deprecate not specifying the argument. (@majosm can explain)
majosm
reviewed
Jul 29, 2024
Co-authored-by: Andreas Klöckner <inform@tiker.net>
majosm
approved these changes
Jul 31, 2024
inducer
reviewed
Jul 31, 2024
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! One and a half more wrinkles, and this should be ready to go.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off #507.
This PR builds off #507 by adding functionality and tests to count duplicates however many times they appear in the DAG. The default functionality is to not count duplicates.