Implement checks on new array types to prevent developer mishaps #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
force-pushed
the
check_eq_attrs
branch
from
f1a334d to
1d1fb5b
Compare
inducer
reviewed
Oct 19, 2022
Owner
inducer
left a comment
inducer
left a comment
There was a problem hiding this comment.
Thanks! A few follow-ups below, otherwise LGTM!
pytato/array.py
Outdated
| _mapper_method: ClassVar[str] = "map_data_wrapper" | ||
|
|
||
| def __post_init__(self) -> None: | ||
| pass |
Owner
There was a problem hiding this comment.
- Add a comment to explain?
- This somehow feels quite broad, in that it assumes that the checks are the only thing happening in
__post_init__? This might make more sense if the checks were in a sub-method which could then be selectively neutered? I'm not insisting on this, FWIW, merely raising the question.
Collaborator
Author
There was a problem hiding this comment.
Added the comment, thanks!
inducer
reviewed
Oct 19, 2022
kaushikcfd
changed the title
kaushikcfd
force-pushed
the
check_eq_attrs
branch
from
1d1fb5b to
8908a98
Compare
Owner
|
Thanks! |
kaushikcfd
force-pushed
the
check_eq_attrs
branch
from
8908a98 to
321d293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in #365.