add materialization counter #333
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kaushik Kulkarni <15399010+kaushikcfd@users.noreply.github.com>
inducer
reviewed
Jun 1, 2022
| # }}} | ||
|
|
||
|
|
||
| def get_num_materialized(outputs: Union[Array, DictOfNamedArrays]) \ |
Owner
There was a problem hiding this comment.
Suggested change
| def get_num_materialized(outputs: Union[Array, DictOfNamedArrays]) \ | |
| def get_num_materialized_predecessors(outputs: Union[Array, DictOfNamedArrays]) \ |
|
|
||
| def is_materialized(expr: ArrayOrNames) -> bool: | ||
| if (isinstance(expr, Array) and | ||
| any(isinstance(tag, ImplStored) for tag in expr.tags)): |
Owner
There was a problem hiding this comment.
Suggested change
| any(isinstance(tag, ImplStored) for tag in expr.tags)): | |
| expr.tags_of_type(ImplStored)): |
| # }}} | ||
|
|
||
|
|
||
| def get_num_materialized(outputs: Union[Array, DictOfNamedArrays]) \ |
Owner
There was a problem hiding this comment.
My main issue with this approach is that it has at least quadratic complexity. A possible improvement would be a CombineMapper that simply counts the materialized predecessors for each node. I.e. combine is a sum, and each node returns 1 if it's materialized and uses inherited behavior (reduce ("combine") over predecessors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.