Small cleanups in meshmode.mesh #486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Jan 12, 2026
meshmode/mesh/__init__.py
Outdated
Comment on lines
91
to
97
| IndexArray: TypeAlias = np.ndarray[tuple[int], np.dtype[np.integer[Any]]] | ||
|
|
||
| VertexIndices: TypeAlias = np.ndarray[tuple[int, int], np.dtype[np.integer[Any]]] | ||
| VertexArray: TypeAlias = np.ndarray[tuple[int, int], np.dtype[np.floating[Any]]] | ||
|
|
||
| NodesArray: TypeAlias = np.ndarray[tuple[int, int, int], np.dtype[np.floating[Any]]] | ||
| RefNodesArray: TypeAlias = np.ndarray[tuple[int, int], np.dtype[np.floating[Any]]] |
Collaborator
Author
There was a problem hiding this comment.
I've been pretty liberal with adding these local type aliases, mostly because Sphinx expands them, so they don't really show up anywhere. Is it worth starting a meshmode.typing for something like this?
Collaborator
Author
There was a problem hiding this comment.
Tried that, but between Sphinx not being very helpful and a bunch of extra imports in places.. I went with using optype instead. What do you think?
Updated all the uses in meshmode.mesh and meshmode.mesh.processing to use optype instead and it looks pretty good.
alexfikl
force-pushed
the
mesh-cleanup
branch
2 times, most recently
from
f7df0dd to
102887b
Compare
inducer
approved these changes
Jan 12, 2026
Owner
|
Thanks! |
alexfikl
force-pushed
the
mesh-cleanup
branch
from
102887b to
9bf3f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started removing
RUF067yesterday and ended up doing some more random cleanup inmeshmode.mesh. The commits should be self-explanatory.