Add unit testing for project list component #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnindrazaka
requested changes
Aug 18, 2020
Comment on lines
52
to
58
| Promise.resolve([ | ||
| { | ||
| _id: "gaejgea7g8hea", | ||
| name: "jatim park map", | ||
| description: "jatim park map description", | ||
| }, | ||
| ] as any), |
Collaborator
There was a problem hiding this comment.
response dari delete project ini harusnya object project. Bukan array of project
Suggested change
| Promise.resolve([ | |
| { | |
| _id: "gaejgea7g8hea", | |
| name: "jatim park map", | |
| description: "jatim park map description", | |
| }, | |
| ] as any), | |
| Promise.resolve({ | |
| _id: "gaejgea7g8hea", | |
| name: "jatim park map", | |
| description: "jatim park map description", | |
| } as any), |
| expect(cardDescription).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("can show succes notification if delete confirm accepted", async () => { |
Collaborator
There was a problem hiding this comment.
coba tambahin satu case lagi ya, yang can show failed notification if delete failed
cara mock nya bisa kamu lihat di https://github.com/indent-dev/blueprint/blob/master/src/modules/LoggedIn/Project/ProjectForm.test.tsx#L94-L104
Collaborator
Author
There was a problem hiding this comment.
mas mau nanya ini saya udah nambahin casenya tapi gagal soalnya findByTitle itu berlaku untuk satu case aja mas. terus saya rubah ke findAllByTitle dia gak mau juga mas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.